Use ProjectService for linting#59645
Closed
jakebailey wants to merge 8 commits intomicrosoft:mainfrom
Closed
Conversation
jakebailey
commented
Aug 15, 2024
jakebailey
commented
Aug 15, 2024
4 tasks
Member
What would a more apples-to-apples comparison look like with the same rules? |
Member
Author
|
I would just ignore the three root files altogether, then compare before and after. But, those files are small, so I would think the culprit here is actually #59335. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simplifies things, and lets us dogfood the experience.
Slower, but we also have technically enabled typed linting on a handful of new files?